FancyInnovations / FancyInnovations/FancyPlugins

Bug: FancyNpcs Error on Latest Canvas Build (build.789)

Open
#266 0 comments 0 reactions 0 assignees View on GitHub
Priority: Medium Status: Pending Type: Bug
Dominant language
Java
Stars
88
Forks
109
PR merge metrics
No merged PRs in 30d

Description

### In which plugin has the error occurred?

FancyNpcs

### What happened?

Few errors have occurred for starters, prior to updating to the latest Canvas build, NPC displaynames have disappeared on 26.1.2 using FancyNpcs version 2.10.0. This has been already addressed in a prior github issue a few weeks back so this is not the main concern.

The main concern is on the newest Canvas build, Canvas fixes scoreboards and I believe that fix or at least something else may be interfering here. Doing any /npc cmd is throwing an error in my console (I will paste that below). This was working fine prior to updating to the latest build.

No displayname even with one set:
Image
(For context, the text you see above the NPC is a FancyHologram that is placed just slightly above the NPC. The very small vertical "holo" like thing below that and above the NPC is supposed to be where the name is- however there is none showing.)

Error in chat after running any command:
Image

### In which software has the error occurred?

Folia

### Plugin version

2.10.0

### Server version

26.1.2

### Relevant log output

```shell
[17:48:20 INFO]: Andrewfb issued server command: /npc equipment Welcome set offhand @hand
[17:48:20 ERROR]: [FancyNpcs] Exception executing command handler
java.lang.IllegalStateException: Cannot set color for team async
at io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:160) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.world.scores.Scoreboard.ensureMainThread(Scoreboard.java:56) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.world.scores.PlayerTeam.setColor(PlayerTeam.java:205) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.v26_1_1.Npc_26_1_1.update(Npc_26_1_1.java:249) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.api.Npc.updateForAll(Npc.java:147) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.api.Npc.updateForAll(Npc.java:152) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.commands.npc.EquipmentCMD.onEquipmentSet(EquipmentCMD.java:53) ~[?:?]
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:735) ~[?:?]
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:760) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.annotations.MethodCommandExecutionHandler.executeFuture(MethodCommandExecutionHandler.java:88) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl.lambda$coordinateExecution$4(ExecutionCoordinatorImpl.java:121) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1171) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:503) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl$NonSchedulingExecutor.execute(ExecutionCoordinatorImpl.java:53) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1205) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture.thenComposeAsync(CompletableFuture.java:2379) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl.coordinateExecution(ExecutionCoordinatorImpl.java:104) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.StandardCommandExecutor.executeCommand(StandardCommandExecutor.java:91) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.StandardCommandExecutor.executeCommand(StandardCommandExecutor.java:65) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.CommandExecutor.executeCommand(CommandExecutor.java:63) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.bukkit.BukkitCommand.execute(BukkitCommand.java:111) ~[?:?]
at io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigCommand.run(BukkitCommandNode.java:83) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:28) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:102) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:464) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.performCommand(Commands.java:374) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.performCommand(Commands.java:363) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2472) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$0(ServerGamePacketListenerImpl.java:2445) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$tryHandleChat$0(ServerGamePacketListenerImpl.java:2602) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.EntityScheduler.executeTick(EntityScheduler.java:274) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1661) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:460) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:519) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:524) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.canvasmc.canvas.tick.AffinitySchedulerThreadPool$TickThreadRunner.run(AffinitySchedulerThreadPool.java:625) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

[17:57:17 INFO]: Andrewfb issued server command: /npc glowing Welcome disabled
[17:57:17 ERROR]: [FancyNpcs] Exception executing command handler
java.lang.IllegalStateException: Cannot set color for team async
at io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:160) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.world.scores.Scoreboard.ensureMainThread(Scoreboard.java:56) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.world.scores.PlayerTeam.setColor(PlayerTeam.java:205) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.v26_1_1.Npc_26_1_1.update(Npc_26_1_1.java:249) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.api.Npc.updateForAll(Npc.java:147) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.api.Npc.updateForAll(Npc.java:152) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.fancynpcs.commands.npc.GlowingCMD.onGlowing(GlowingCMD.java:46) ~[?:?]
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:735) ~[?:?]
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:760) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.annotations.MethodCommandExecutionHandler.executeFuture(MethodCommandExecutionHandler.java:88) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl.lambda$coordinateExecution$4(ExecutionCoordinatorImpl.java:121) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1171) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:503) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl$NonSchedulingExecutor.execute(ExecutionCoordinatorImpl.java:53) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1205) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture.thenComposeAsync(CompletableFuture.java:2379) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.ExecutionCoordinatorImpl.coordinateExecution(ExecutionCoordinatorImpl.java:104) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.StandardCommandExecutor.executeCommand(StandardCommandExecutor.java:91) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.StandardCommandExecutor.executeCommand(StandardCommandExecutor.java:65) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.execution.CommandExecutor.executeCommand(CommandExecutor.java:63) ~[?:?]
at FancyNpcs-2.10.0.jar//de.oliver.cloud.bukkit.BukkitCommand.execute(BukkitCommand.java:111) ~[?:?]
at io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigCommand.run(BukkitCommandNode.java:83) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:28) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:102) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:464) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.performCommand(Commands.java:374) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.commands.Commands.performCommand(Commands.java:363) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2472) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$0(ServerGamePacketListenerImpl.java:2445) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$tryHandleChat$0(ServerGamePacketListenerImpl.java:2602) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.EntityScheduler.executeTick(EntityScheduler.java:274) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1661) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:460) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:519) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:524) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at io.canvasmc.canvas.tick.AffinitySchedulerThreadPool$TickThreadRunner.run(AffinitySchedulerThreadPool.java:625) ~[canvas-26.1.2.jar:26.1.2-789-87df111]
at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.