FancyInnovations / FancyInnovations/FancyPlugins

Bug: FancyHolograms: Block Display tab complete watchdog error

Open
#253 0 comments 0 reactions 0 assignees View on GitHub
Priority: Medium Status: Pending Type: Bug
Dominant language
Java
Stars
88
Forks
109
PR merge metrics
No merged PRs in 30d

Description

### In which plugin has the error occurred?

FancyHolograms

### What happened?

Fancyholograms blocks the thread when initializing block list for the tab complete. Also it initializes the legacy material support which prints a warning in the console.
This can be resolved by either just using bukkit block registry (easy fix) or using brigadier argument BlockStateArgument (requires command system overhaul)
I'd recommend switching to brigadier api since it provides much more powerful command and tab complete system.
Also I noticed that block displays in fancyholograms doesn't support blockdata such as waterlogged, powered.

### In which software has the error occurred?

Folia

### Plugin version

2.10.0

### Server version

26.1.2

### Relevant log output

```shell
[10:57:50 WARN]: [org.bukkit.craftbukkit.legacy.CraftLegacy] Initializing Legacy Material Support. Unless you have legacy plugins and/or data this is a bug!
[10:57:55 ERROR]: [io.papermc.paper.threadedregions.FoliaWatchdogThread] Tick region located in world 'world' around chunk '[2, 1]' has not responded in 5.0018906s:
[10:57:55 ERROR]: ------------------------------
[10:57:55 ERROR]: Current Thread: Folia Region Scheduler Thread #0
[10:57:55 ERROR]: PID: 67 | Suspended: false | Native: false | State: RUNNABLE
[10:57:55 ERROR]: Stack:
[10:57:55 ERROR]: com.mojang.datafixers.types.templates.Named$NamedType.equals(Named.java:153)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.equals(Type.java:278)
[10:57:55 ERROR]: java.base@25.0.2/java.util.Objects.equals(Objects.java:62)
[10:57:55 ERROR]: com.mojang.datafixers.FieldFinder$Matcher.match(FieldFinder.java:88)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findType(Type.java:237)
[10:57:55 ERROR]: com.mojang.datafixers.types.templates.Sum$SumType.findTypeInChildren(Sum.java:242)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.lambda$findType$17(Type.java:239)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x000000002777a308.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findType(Type.java:237)
[10:57:55 ERROR]: com.mojang.datafixers.types.templates.Product$ProductType.findTypeInChildren(Product.java:240)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.lambda$findType$17(Type.java:239)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x000000002777a308.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findType(Type.java:237)
[10:57:55 ERROR]: com.mojang.datafixers.types.templates.Hook$HookType.findTypeInChildren(Hook.java:142)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.lambda$findType$17(Type.java:239)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x000000002777a308.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findType(Type.java:237)
[10:57:55 ERROR]: com.mojang.datafixers.types.templates.Named$NamedType.findTypeInChildren(Named.java:175)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.lambda$findType$17(Type.java:239)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x000000002777a308.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findType(Type.java:237)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.findTypeCached(Type.java:233)
[10:57:55 ERROR]: com.mojang.datafixers.FieldFinder.findType(FieldFinder.java:36)
[10:57:55 ERROR]: com.mojang.datafixers.OpticFinder.findType(OpticFinder.java:16)
[10:57:55 ERROR]: com.mojang.datafixers.Typed.getOptional(Typed.java:65)
[10:57:55 ERROR]: net.minecraft.util.datafix.fixes.ItemStackMapIdFix.lambda$makeRule$0(ItemStackMapIdFix.java:27)
[10:57:55 ERROR]: net.minecraft.util.datafix.fixes.ItemStackMapIdFix$$Lambda/0x000000002775be00.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.DataFix.lambda$checked$3(DataFix.java:98)
[10:57:55 ERROR]: com.mojang.datafixers.DataFix$$Lambda/0x00000000277786f0.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.applyUnchecked(Comp.java:126)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.lambda$eval$2(Comp.java:118)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp$$Lambda/0x00000000277784a0.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.lambda$mapRight$0(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$$Lambda/0x000000002778c508.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either$Right.map(Either.java:99)
[10:57:55 ERROR]: com.mojang.datafixers.util.Either.mapRight(Either.java:166)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance.lambda$right$6(FunctionType.java:104)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$Instance$$Lambda/0x000000002778b4d8.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function.lambda$compose$0(Function.java:68)
[10:57:55 ERROR]: java.base@25.0.2/java.util.function.Function$$Lambda/0x0000000026eeef08.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.FunctionType$$Lambda/0x000000002778b270.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.applyUnchecked(Comp.java:126)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.lambda$eval$2(Comp.java:118)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp$$Lambda/0x00000000277784a0.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Fold.lambda$eval$2(Fold.java:91)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Fold$$Lambda/0x0000000027786008.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.applyUnchecked(Comp.java:126)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp.lambda$eval$2(Comp.java:118)
[10:57:55 ERROR]: com.mojang.datafixers.functions.Comp$$Lambda/0x00000000277784a0.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.capWrite(Type.java:167)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.lambda$readAndWrite$10(Type.java:159)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x0000000027778000.apply(Unknown Source)
[10:57:55 ERROR]: com.mojang.serialization.DataResult$Success.flatMap(DataResult.java:201)
[10:57:55 ERROR]: com.mojang.datafixers.types.Type.readAndWrite(Type.java:158)
[10:57:55 ERROR]: com.mojang.datafixers.DataFixerUpper.update(DataFixerUpper.java:78)
[10:57:55 ERROR]: org.bukkit.craftbukkit.legacy.CraftLegacy.(CraftLegacy.java:437)
[10:57:55 ERROR]: org.bukkit.craftbukkit.util.CraftMagicNumbers.fromLegacy(CraftMagicNumbers.java:244)
[10:57:55 ERROR]: org.bukkit.Material.lambda$new$1(Material.java:2791)
[10:57:55 ERROR]: org.bukkit.Material$$Lambda/0x0000000025ac9ac8.get(Unknown Source)
[10:57:55 ERROR]: com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:201)
[10:57:55 ERROR]: org.bukkit.Material.asBlockType(Material.java:3669)
[10:57:55 ERROR]: org.bukkit.Material.isBlock(Material.java:2996)
[10:57:55 ERROR]: FancyHolograms-2.10.0.jar//de.oliver.fancyholograms.commands.HologramCMD$$Lambda/0x00000000277163c0.test(Unknown Source)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:196)
[10:57:55 ERROR]: java.base@25.0.2/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:635)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:291)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:652)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:658)
[10:57:55 ERROR]: java.base@25.0.2/java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:663)
[10:57:55 ERROR]: FancyHolograms-2.10.0.jar//de.oliver.fancyholograms.commands.HologramCMD.tabComplete(HologramCMD.java:228)
[10:57:55 ERROR]: org.bukkit.command.Command.tabComplete(Command.java:100)
[10:57:55 ERROR]: io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigSuggestionProvider.getSuggestions(BukkitCommandNode.java:109)
[10:57:55 ERROR]: com.mojang.brigadier.tree.ArgumentCommandNode.listSuggestions(ArgumentCommandNode.java:71)
[10:57:55 ERROR]: com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:550)
[10:57:55 ERROR]: com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:530)
[10:57:55 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.sendServerSuggestions(ServerGamePacketListenerImpl.java:954)
[10:57:55 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleCustomCommandSuggestions0$0(ServerGamePacketListenerImpl.java:916)
[10:57:55 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl$$Lambda/0x00000000276d7d88.accept(Unknown Source)
[10:57:55 ERROR]: io.papermc.paper.threadedregions.EntityScheduler.executeTick(EntityScheduler.java:274)
[10:57:55 ERROR]: net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1759)
[10:57:55 ERROR]: net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:451)
[10:57:55 ERROR]: io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:485)
[10:57:55 ERROR]: io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:481)
[10:57:55 ERROR]: ca.spottedleaf.concurrentutil.scheduler.EDFSchedulerThreadPool$TickThreadRunner.run(EDFSchedulerThreadPool.java:528)
[10:57:55 ERROR]: ca.spottedleaf.concurrentutil.util.LazyRunnable.run(LazyRunnable.java:25)
[10:57:55 ERROR]: java.base@25.0.2/java.lang.Thread.runWith(Thread.java:1487)
[10:57:55 ERROR]: java.base@25.0.2/java.lang.Thread.run(Thread.java:1474)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.