Famous / Famous/engine

[Question] Expand or Extend Size Modes

Open
#372 6 comments 0 reactions 0 assignees View on GitHub
controversial enhancement
Dominant language
JavaScript
Stars
1.7k
Forks
249
PR merge metrics
No merged PRs in 30d

Description

I have a usecase for a new size mode `MIN_ABSOLUTE` where the calculation is:

```
target[i] = parentSize[i] * this.proportionalSize[i] + this.differentialSize[i];
var absolute = this.absoluteSize[i];
if (absolute > target[i]) {
target[i] = absolute;
}
```

I can put in a PR and easily add this to the existing types...
_OR_
Should `Size` be opened up to allow custom size modes to be included? I am more in favor of this approach and will work up a PR for the custom size modes. But thought I would see if there are any opinions on the matter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.