Fallout-build / Fallout-build/Fallout
Environment Variables prepended with `FALLOUT_` don't work.
- Dominant language
- C#
- Stars
- 154
- Forks
- 19
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 15
Description
### Usage Information
10.3.49
### Description
Contrary to the information stated in the documentation for [Parameters](https://github.com/Fallout-build/Fallout/blob/f57634c5636bf5ba4fd0f49eaf0f8360697abcb3/docs/02-fundamentals/06-parameters.md?plain=1#L81), the code is still looking for `NUKE_`.
Problem Code:
https://github.com/Fallout-build/Fallout/blob/f57634c5636bf5ba4fd0f49eaf0f8360697abcb3/src/Fallout.Build/Execution/ParameterService.cs#L192
I can create a PR later to address this, but I am unsure if it should also remain compatible with `NUKE_`. LMK what you think.
### Reproduction Steps
1. Create Build Project
2. Add a string parameter.
3. Assert in target when parameter is null.
4. `export FALLOUT_MY_PARAMETER_NAME="hello"`
5. Run build, reach assertion.
6. `export NUKE_MY_PARAMETER_NAME="hello"`
7. Run build, no assertion.
### Expected Behavior
Environment variables prepended with `FALLOUT_` should be used for parameters as per documentation.
### Actual Behavior
See Repro.
### Regression?
Kind of. Technically?
### Known Workarounds
_No response_
### Could you help with a pull-request?
Yes
Contributor guide
Assessment
This issue has not been assessed yet.