should we call initVvtShape for non-decoder cam types?
Open
- Dominant language
- C
- Stars
- 138
- Forks
- 69
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 4
Description
Some cam types don't use a real decoder (toyota 3 tooth, single tooth, etc).
Yet we still call `initVvtShape`, which then requires we have code like
```
case trigger_type_e::TT_VVT_TOYOTA_3_TOOTH:
initializeSkippedToothTrigger(this, 3, 0, triggerOperationMode, SyncEdge::RiseOnly);
break;
```
Contributor guide
Research direction
Start by tracing `initVvtShape` and the handling of `trigger_type_e::TT_VVT_TOYOTA_3_TOOTH` and other non-decoder cam types. Determine whether these types should bypass that initialization or retain dedicated trigger setup; done means their initialization no longer requires inappropriate decoder cases and existing trigger behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100