FOME-Tech / FOME-Tech/fome-fw

Ignition output config causing confusion

Open
#596 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
138
Forks
69
Avg merge
5d 20h
Merged PRs (30d)
4

Description

Ignition pin configuration menu is causing confusion again, just had to look at a V8 wasted spark with ignition timing problems.
Coil pairing is: 1->1+6, 2->5+8, 3->7+4, 4->2+3
Config was set like this:

![Image](https://github.com/user-attachments/assets/94898f41-383e-49b8-8cd2-2d0cfcdf0527)

But in reality needs to be set like this:

![Image](https://github.com/user-attachments/assets/46e4447e-9682-41b8-8984-b5462a43780e)

It seems to me where we have "ignition pin x" really should be "cylinder 8"

The order of the outputs does follow the firing order, so it is possible to just refer to that when setting the outputs, however I think if it said "cylinder" instead then it would be simpler for users.

![Image](https://github.com/user-attachments/assets/bb5b51e4-08d8-4ed7-9085-fef30e3bdfbf)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.