FOME-Tech / FOME-Tech/fome-fw

cannot calibrate ETB/TPS without accel pedal

Open
#433 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
138
Forks
69
Avg merge
5d 20h
Merged PRs (30d)
4

Description

`EtbController` won't return successful `init` unless there's an accel pedal present: https://github.com/FOME-Tech/fome-fw/blob/master/firmware/controllers/actuators/electronic_throttle.cpp#L165

This seems unnecessary, for both TPS auto-calibration and PID autotune.

Perhaps `init` should remove this check? Unsure how ETB pedal target (`m_pedalMap`) would behave if no channels configured.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.