negative timing is not displayed correctly in two stroke mode
Open
- Dominant language
- C
- Stars
- 138
- Forks
- 69
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 4
Description
```
// that's weird logic. also seems broken for two stroke?
engine->outputChannels.ignitionAdvance = (float)(advance > FOUR_STROKE_CYCLE_DURATION / 2 ? advance - FOUR_STROKE_CYCLE_DURATION : advance);
```
As the code comment says - it's broken for two stroke. See https://github.com/rusefi/rusefi/commit/5d46bb1074ca5a0c97f8654d43d99aec95ebe6d6 which includes unit test
Contributor guide
Assessment
This issue has not been assessed yet.