FOME-Tech / FOME-Tech/fome-fw

doubled injections possible on negative fueling transients

Open
#30 1 comment 0 reactions 0 assignees View on GitHub
🐞 bug 🐞
Dominant language
C
Stars
138
Forks
69
Avg merge
5d 20h
Merged PRs (30d)
4

Description

crank to run transition

![image](https://user-images.githubusercontent.com/568254/220864304-f4bb5614-8afc-4488-9845-92b1f98b23d5.png)

Note that the duration of these two intervals is approximately the same:

![image](https://user-images.githubusercontent.com/568254/220864376-f200456c-1679-41e7-a45a-a534afce6146.png)

What's happening is that the first small injection is scheduled, then the injection phase is updated, then at the next tooth its scheduled AGAIN. Since we target the end-of-injection timing, the first injection got scheduled expecting the duration of the longer cranking pulse, not the shorter running pulse.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the crank-to-run transition described in the issue and compare the two injection intervals shown in the screenshots. Trace where the first injection is scheduled and where the injection phase is updated; done means the transition no longer schedules the same negative fueling transient twice.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.