FOME-Tech / FOME-Tech/fome-fw

Knock control : Reapply rate as % of aggression

Open
#193 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
138
Forks
69
Avg merge
5d 20h
Merged PRs (30d)
4

Description

Current method of degrees/second is too slow at low load and too fast at high load. (also hard to pick a reasonable base value).

The aggression was designed to vary the size of the retard steps with the ignition advance, using a % of aggression to do the reapply will also allow it to scale with the size of the retard steps.

Suggest we use a base value of about 30% of the aggression value, that way we will re-advance at ~1/3rd any step calculated for retard.

![image](https://github.com/FOME-Tech/fome-fw/assets/49926376/9111eeca-0e7b-4236-a07f-c57938d2444e)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.