FOLIO-FSE / FOLIO-FSE/folio_migration_tools

Provide more detail in report on sub-objects that were not created due to missing required properties

Open
#574 0 comments 0 reactions 0 assignees View on GitHub
2025 Review Migration Reports Tool enhancements
Dominant language
Python
Stars
14
Forks
10
Avg merge
55m
Merged PRs (30d)
7

Description

From discussion in https://github.com/FOLIO-FSE/folio_migration_tools/pull/567

> What I wonder is if we should report failing required mappings to the data issues log as well under certain circumstances. It could be that an otherwise complete objects is missing the required field for some reason. In that case, it could be hard to find this record, right?

> Agree. We agreed we need to make sure we don't report individual objects as failing unless removed object contained a legacy value (not just a bool or a value hardcoded into the map).
> I think the way now to identify the records would be to search in the source data for ones that don't have one of the required properties.
> Maybe as a first step we could report e.g.
> Incomplete "contacts" object removed (contains properties ["name", "isPrimary"], missing required properties ["code"])

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.