FNNDSC / FNNDSC/pfcon

Copy job runs with same resource request/limit as plugin instance

Open
#173 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
11
Forks
25
PR merge metrics
No merged PRs in 30d

Description

https://github.com/FNNDSC/pfcon/blob/ed00eba024e867b1430645c8c5ce5bb29373b125/pfcon/resources.py#L216-L244

This is inefficient in both extremes:

- If the _ChRIS_ plugin is a very simple compiled program, a plugin developer might set `max_memory_limit=12Mi` and `max_cpu_limit=10m`. However, this causes the `fnndsc/pfconopjob` container to fail to start.
- If the _ChRIS_ plugin is a computationally demanding program (which is often the case for image processing), the `fnndsc/pfconopjob` container will have way more CPU and memory allocated than it needs.

Would it be possible for the resource request/limit for pfcon's "async" jobs (copy, upload, delete) to use resource request/limits which are independent of the plugin instance's configuration?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.