FNNDSC / FNNDSC/ami

MIP method of thicknessMethod probably don't consider the current slice orientation

Open
#392 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
745
Forks
212
PR merge metrics
No merged PRs in 30d

Description

### Description
When using MIP method (default thickness method with some >0 thickness slice setting) with non-axial slice, it displays some repeated pattern. It seems like the direction that max intensity is calculated is not perpendicular to the slice plane. I am not sure if this is the expected result of MIP, or it is really a bug.

For example, this is a part of coronal view without MIP method (slice thickness = 0)
![mipoff](https://user-images.githubusercontent.com/3810893/63875042-3d0ddd00-c9f5-11e9-8ef4-7bc1c0232bd5.jpg)
And when MIP method is turned on, the pattern are repeated (and there is no such problem in the axial view).
![mipon](https://user-images.githubusercontent.com/3810893/63875045-3d0ddd00-c9f5-11e9-89eb-a06b916e456f.jpg)

#### Live Demo
Similar behavior can be found in the [geometries slice example](https://fnndsc.github.io/ami/#geometries_slice).
Set thickness to some value > 10. In some direction, you would see some ripple-like pattern and the bright area seems expanded.
Screen Shot 2019-08-29 at 00 31 47

### Browsers Affected
- [x] All
- [ ] Chrome
- [ ] Firefox
- [ ] Edge
- [ ] Safari 9
- [ ] Safari 8
- [ ] IE 11

### Versions
- AMI: locally using v0.22.0, don't know which version is used by the demo site (have cloned and run the latest code, it has the same problem.)
- THREEJS: locally using v0.93.0, demo site using v0.107.0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.