FISCO-BCOS / FISCO-BCOS/web3sdk

WalletUtils.isValidAddress() 只检查String长度

Open
#228 0 comments 0 reactions 3 assignees Claimed by @fqliao View on GitHub
Dominant language
Java
Stars
122
Forks
81
PR merge metrics
No merged PRs in 30d

Description

String addr1 = "0x0cc37d28ff272d0f92a402d29af4efc334bf3c7*";
return WalletUtils.isValidAddress(addr1);

这里返回的是true,因为代码里只做了长度检查

建议:首先检查是否为Hex字符串
WeID里面使用的正则表达式:0x[a-fA-f0-9]{40}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.