FIRST-Tech-Challenge / FIRST-Tech-Challenge/scorekeeper

Ready and score submission state doesn't reset when replaying a match

Open
#760 0 comments 0 reactions 0 assignees View on GitHub
bug Local
Dominant language
No language data
Stars
110
Forks
26
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
If a match is replayed the status that the teams are ready and refs have submitted scores does not get cleared. This means that for the replayed match when it is loaded it shows both alliances ready and the second the match ends both scores show up green on the match control page indicating score is ready to post even if the refs have not yet submitted final scores on the tablets.

**To Reproduce**
Steps to reproduce the behavior:
1. Run a match as normal
2. Refs submit teleop and final scores on the tablet
3. Observer both red and blue scores are green on the match control page
4. Replay the match
5. Observe both red and blue alliances show green for teams ready before refs submit alliance ready.
6. Play the mathc
7. After match ends observe red and blue scores are green before being submitted on the tablets.

**Expected behavior**
When replaying the match all state of the first run should be reset including the alliance ready state and the score submission state.

**Screenshots**
N/A

**Device (please complete the following information):**
- Version 6.1.3

**Additional context**
Luckily our scorekeeper caught what was happening, but this almost caused us to announce a score before it had been finalized by the ref crew this last weekend.

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. Start by reproducing the listed replay flow and trace where replayed match state is loaded for the match control page and score tablets; done means alliance-ready and score-submission indicators are cleared before the replay, then become green only after the new submissions.

Written by the indexing model from the issue text.

Assessment

Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.