FIRST-Tech-Challenge / FIRST-Tech-Challenge/scorekeeper

[FTC-Events API] Advancement from LT -> State CMP does not match what is configured in FTC Scoring

Open
#687 1 comment 0 reactions 0 assignees View on GitHub
bug ftc-events
Dominant language
No language data
Stars
110
Forks
26
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
In FTC Scoring, we have league tournaments in our region that are configured to advance to the state championship. Using the API, we can see the number of teams advancing from the state championship to *FIRST* Championship.

```
❯ curl --user [...] https://ftc-api.firstinspires.org/v2.0/2023/advancement/USWACMP
{"advancesTo":"FTCCMP1","slots":4,"advancement":null}%
```

However, for advancement from the previous layer, league tournaments to states, the API returns "0", despite the events being configured with advancement in FTC Scoring.

```
❯ curl --user [...] https://ftc-api.firstinspires.org/v2.0/2023/advancement/USWAFELT1
{"advancesTo":"USWACMP","slots":0,"advancement":null}%
```

```
❯ curl --user [...] https://ftc-api.firstinspires.org/v2.0/2023/advancement/USWACMP/source
[..., {"advancedFrom":"USWAFELT1","advancedFromRegion":null,"slots":0,"advancement":null}, ...]%
```

FTC Scoring screenshot

**To Reproduce**
Steps to reproduce the behavior:
1. Have one level of regional play advance to another, with # of teams configured in FTC Scoring (i.e. USWAFELT1 -> USWACMP)
2. Send an authenticated request to the FTC API advancement endpoints
3. Observe "slots" is equal to 0 despite having a non-zero value in FTC Scoring

**Expected behavior**
The API should return the number of advancement slots as configured in FTC Scoring.

**Device (please complete the following information):**
- OS: [e.g. iOS] macOS Sonoma 14.2.1
- Browser [e.g. chrome, safari] curl
- Version [e.g. 22] 8.4.0

**Additional context**
Possible additional nuance: Is there a usecase where advancement is configured in FTC Scoring, but is not meant to be known by the public yet? As in, having it accessible in the API would "leak" the number of advancement slots to the next level?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.