FHIR / FHIR/sushi

Img closing tags removed from XHTML tags

Open
#1,048 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
188
Forks
64
Avg merge
8d 11h
Merged PRs (30d)
3

Description

Because `img` tags are empty elements, they should not have any inner content. SUSHI tries to minify the XHTML and the minifier removes the closing `` tag. Example from Zulip in FSH Online [here](https://fshschool.org/FSHOnline/#/share/35ZHcND). While this is not valid XHTML, it is probably okay that SUSHI does this, but we might be able to better warn the users to alert them to what happened.

See: https://chat.fhir.org/#narrow/stream/215610-shorthand/topic/Weird.20non-rendering.20of.20xhtml.20in.20generated.20resource/near/275690452

Contributor guide

Open the contributing guide

Research direction

Reproduce the Zulip example through the linked FSH Online share and inspect the XHTML minification path responsible for removing the closing img tag. Confirm the resulting output and determine a clear warning for users; done means the behavior is intentionally communicated without breaking generated resources.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.