FGRibreau / FGRibreau/node-request-retry
request from defaults() method ignores options argument in some cases.
- Dominant language
- JavaScript
- Stars
- 346
- Forks
- 73
- PR merge metrics
- No merged PRs in 30d
Description
request from defaults() method ignores options argument in some cases.
```javascript
var request = require('requestretry').defaults({
headers: {
'User-Agent': 'default UA'
}
});
// OK
request('https://github.com/', function (err, response, body) {
});
// NOT OK - Referer header is not sent
request('https://github.com/', {
headers: {
Referer: 'https://www.apple.com/'
}
}, function (err, response, body) {
});
// OK
request({
url: 'https://github.com/',
headers: {
Referer: 'https://www.apple.com/'
}
}, function (err, response, body) {
});
// OK
request.get('https://github.com/', {
headers: {
Referer: 'https://www.apple.com/'
}
}, function (err, response, body) {
});
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.