FEX-Emu / FEX-Emu/FEX

Code Invalidation: RemoveCode shouldn't free IRLists, as that breaks self-invalidation in interpreter

Open
#808 0 comments 0 reactions 1 assignee Assigned to @skmp View on GitHub
Dominant language
C++
Stars
8k
Forks
351
Avg merge
12h 31m
Merged PRs (30d)
102

Description

Follow up from #705

If the interpreter invalidates (either via syscall, or op_removecodeentry) it needs to run the current block to the block exit. We should "stage" removed code blocks to a "to free" list, and GC them at a point where we're sure we're not running them.

This doesn't affect the jit as it doesn't reference the ir data during runtime

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.