FEX-Emu / FEX-Emu/FEX

What is the extra slot used for? (I.e. why not just `MAX_SIGNALS` elements?)

Open
#1,615 0 comments 0 reactions 1 assignee Assigned to @skmp View on GitHub
Dominant language
C++
Stars
8k
Forks
351
Avg merge
12h 31m
Merged PRs (30d)
102

Description

What is the extra slot used for? (I.e. why not just `MAX_SIGNALS` elements?)

_Originally posted by @neobrain in https://github.com/FEX-Emu/FEX/pull/1613#discussion_r823493879_

This is an antipattern seen through our signal handling due to signals using 1 based indexing with 0 being special cased.
Resolve this pattern and come back to it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.