FAForever / FAForever/fa

[missing_nill_check] Game sometimes crashes right before the loading game animation in custom lobbys (stuck in black screen)

Open
#5,301 3 comments 0 reactions 0 assignees View on GitHub
area: engine area: lobby type: bug
Dominant language
Lua
Stars
264
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
21

Description

**Describe the bug**
Games crashes when pressing start game

**To Reproduce**
Seems to happen if someone connects to observer when starting the game

**Expected behavior**
i expect the game to not crash
[game_20507620.log](https://github.com/FAForever/fa/files/12245692/game_20507620.log)

```
Command line:
C:\ProgramData\FAForever\bin\ForgedAlliance.exe /init init.lua /nobugreport /log "%USER_PROFILE%\AppData\Roaming\Forged Alliance Forever\logs\game_20507620.log" /gpgnet 127.0.0.1:58417 /mean 1352.5756 /deviation 104.0993 /savereplay gpgnet://127.0.0.1:58415/20507620/%USER%.SCFAreplay /country FR /numgames 531 /numgames 446

Exit code: 1
Engine ver.: 3764
Game tick: 0

C++ Exceptions:
.?AUlua_RuntimeError@@
Main thread
@c:\programdata\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua 5500
CObject:.?AVCLobby@Moho@@, Table
@c:\programdata\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua 5511
Table
@c:\programdata\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua 5197
nil, -1, nil, Table, 16, 1, Table, true, Table
@c:\programdata\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua 7104
Table, nil, nil, nil, "attempt to call local `value' (a nil v

alue)", "...lua\ui\lobby\data\watchedvalue\watchedvaluetable.lua(54): attempt to call local `value' (a nil value)
stack traceback:
...lua\ui\lobby\data\watchedvalue\watchedvaluetable.lua(54): in function <...lua\ui\lobby\data\watchedvalue\watchedvaluetable.lua:44>
...ta\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua(7104): in function `ConvertObserverToPlayer'
...ta\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua(5197): in function `Handle'
...ta\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua(5511): in function <...ta\faforever\gamedata\lua.nx2\lua\ui\lobby\lobby.lua:5500>"

Debug messages:
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.