FAForever / FAForever/fa

(S)ACU drone upgrades are removed when drones are defeated

Open
#5,114 1 comment 0 reactions 0 assignees View on GitHub
area: sim
Dominant language
Lua
Stars
264
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
21

Description

**Describe the bug**
Both UEF SACUs and ACUs drone upgrades are removed if the auto-rebuild button is disabled.
When the drones are destroyed, the upgrades are removed from the unit in question.

---

**To Reproduce**
Sandbox Game:
- Spawn in a UEF ACU and SACU then upgrade each of them with a drone upgrade. (Engineer Preset for the SACU works as well.)
- Select the drone, then disable the drone auto-rebuild button.
- Destroy the Drones.
- Observe SACU and ACU upgrades.

Notice how the drone upgrades themselves are completely removed.
This forces the player to idle the unit while they obtain the upgrades again.

---

**Expected behavior**
When Auto-Rebuild is disabled, drones are not rebuilt when destroyed, and upgrades are retained.

---

**Screenshots**

Before:
![image](https://github.com/FAForever/fa/assets/121060254/7479aab6-e2dc-4dd2-94f4-2a57fee46271)

---

During:
![image](https://github.com/FAForever/fa/assets/121060254/ef0e7494-15a9-4993-a530-e4ce3aa19094)

---

After:
![image](https://github.com/FAForever/fa/assets/121060254/be803ca6-5bd5-46ef-b54a-26a84144254d)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.