FAForever / FAForever/fa

Smoke effects on units and buildings are missing

Open
#4,840 3 comments 0 reactions 0 assignees View on GitHub
area: graphics
Dominant language
Lua
Stars
264
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
21

Description

**Describe the bug**
It seems that this pull request https://github.com/FAForever/fa/pull/3714 inadvertently removed the continued smoke effects on exploded units.

**To Reproduce**
When you ctrl-k some units or buildings the explosion animation plays as normal.

After that some units continued to smoke for a considerable time, either with a very narrow smoke trail or with more turbulent diffusing smoke. These effects are gone after the commit of that PR.

**Expected behavior**
I believe that this was a mistake as I don't see it mentioned in the PR and I don't know why we would remove it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.