FAForever / FAForever/fa

Init file incorrectly detects duplicated sounds for VOs

Open
#4,632 1 comment 0 reactions 0 assignees View on GitHub
area: Audio
Dominant language
Lua
Stars
264
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
21

Description

Code in question https://github.com/FAForever/fa/blob/deploy/fafdevelop/init_faf.lua#L295-L321

This sounds loading code assumes that sound banks are all directly in the `sounds` folder, but that's not true for voice overs, those always need to be in `sounds/voice/LANGUAGE/bankName.xsb`

So the current code will load the first map with voices and save the `voice` folder incorrectly as a sound bank and won't load any additional VOs in others maps.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.