FAForever / FAForever/fa

Missing register key spam when audio is running

Open
#3,350 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Lua
Stars
264
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
21

Description

If you run Process Monitor and filter out ForgedAlliance.exe there's a noticable spam of register key not found while audio is playing in the game (~10 per second)

![image](https://user-images.githubusercontent.com/254972/129339030-eb3a9189-18af-4e88-968c-32af8dbdaa28.png)

There was an earlier discussion in the old forum about this:
https://forums.faforever.com/viewtopic.php?f=2&t=9451

Especially the last message this was interesting:

> With the help of SeraphimLeftNut and mr_ped I've created a fix for the APL key spam. It's in the form of a dll and a dll injector application. The dll installs a detour on the RegQueryValueExA function imported from Advapi32.dll and blocks all calls where lpSubKey == _T("SOFTWARE\\Microsoft\\APL") by returning 0x2. This completely stops the spam.

> What effect this has on performance is unknown.

Could be worth investigating when someone is bored enough.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.