FAForever / FAForever/client

Make builds somewhat reproducible

Open
#527 0 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Python
Stars
78
Forks
89
PR merge metrics
No merged PRs in 30d

Description

Some of our build steps in appveyor and travis don't pin the version of some dependencies, [like here in the lua-dist in appveyor](https://github.com/FAForever/client/blob/develop/appveyor.yml#L15):

git clone https://github.com/LuaDist/lua.git

While principally I believe we should always build with the newest dependencies if possible, we should also make sure the version of all dependencies are always recorded so if a build suddenly breaks for no apparent reason we can check if the problem is with a dependency.

This mainly means fixing up the appveyor and travis scripts to make sure that e.g. the commit hash of a git repo we use as dependency is printed with the build.

This should be an easy fix and is probably interesting for anyone who wants to get their feet wet with travis and appveyor.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.