FAForever / FAForever/client

map file check uses foldernames for files instead of scenario.lua

Open
#1,046 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
78
Forks
89
Avg merge
22d 15h
Merged PRs (30d)
1

Description

https://github.com/FAForever/client/blob/ecf3715c9d3851401d82d095dc46fca3edf72f44/src/fa/maps.py#L101-L112

The map files can be named differently than the foldername of the maps, but the check for valid map files only tries the foldername instead of the paths that are stored inside of the scenario.lua file. Maps that differ from that naming convention wont be loaded when selecting them in the hostgame-popup and the default map (Four Corners) will be opened instead. Switching to the map inside of the game lobby (and launching it) works fine.

![grafik](https://user-images.githubusercontent.com/21953792/40686623-37fdf9ae-6398-11e8-8b28-2d3cbe63ba28.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.