Extendy / Extendy/SmartyURL

Comment Lines // in JavaScript Not Removed When Minifying

Open
#72 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
CSS
Stars
16
Forks
3
PR merge metrics
No merged PRs in 30d

Description

When the `smartyurl.minifyHtmloutput` setting is enabled (set to true), comment lines in JavaScript code that use // are not removed during the minification process. For example:

// set the redirectCondition
var redirectCondition = document.getElementById("redirectCondition");
redirectCondition.value = "device";

This can result in errors in the JavaScript code.

Suggested Solution:

If you're a SmartyURL developer or creating tools and UI for SmartyURL, we recommend using /* */ for comments in JavaScript output instead of // while we address this issue. This ensures proper comment handling during the minification process.

We appreciate your understanding, and we'll address this issue in an upcoming update.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.