ExtendRealityLtd / ExtendRealityLtd/Malimbe

Overhaul AssemblyNameRegex

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
52
Forks
10
PR merge metrics
No merged PRs in 30d

Description

`AssemblyNameRegex` in the `FodyWeavers.xml` files should be restricting the assemblies the particular configuration file affects.

Currently the setting just gets merged across files, but it makes more sense to allow setting all settings, including the list of weavers to run for specific assemblies. This allows a library component to use Malimbe (configured with the library's settings) while also allowing any user of that library to use Malimbe with different settings.

Perhaps `AssemblyNameRegex` should move into the root-level element `Weavers` instead? This would need to still allow specifying _multiple_ assemblies, which should be easily possible since it's treated as a regex after all.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.