Explore-Beyond-Innovations / Explore-Beyond-Innovations/ZeroXBridge_Frontend

wallet is unable to connect. infinite render of an ethereum (phantom) wallet popup

Open
#248 2 comments 0 reactions 0 assignees View on GitHub
Test Wave
Dominant language
TypeScript
Stars
32
Forks
70
PR merge metrics
No merged PRs in 30d

Description

a specific commit has broken the process of connecting a wallet.

my best guess is this commit ([d9afffb](https://github.com/kaf-lamed-beyt/ZeroXBridge_Frontend/commit/d9afffbbea8ec88b60a7b34536e696ae6ebd0517)) in particular. on my computer when i tested the latest changes, i ran into this infinite rendering of the phantom wallet as i've described in this issue: https://github.com/Explore-Beyond-Innovations/ZeroXBridge_Frontend/issues/241

i had to go some steps back into the commit history where there's a stable version of the code, and connecting a wallet just works fine as we've always had it.

https://github.com/user-attachments/assets/d1c7128c-b141-4949-8c8c-ea1bff5d4e1d

while walking through #241 with @emmanueloloke, we figured out that even connecting a StarkNet wallet is impossible. see the respective error:

Image

@kabugatti, could you walk me through what the essence of this function (👇🏼) is?

https://github.com/kabugatti/ZeroXBridge_Frontend/blob/2419c3d61673c5316ca9130c9e767e6de85e7e01/app/hooks/useWallet.ts#L19-L62

i also believe that the `useWallet` hook file should not have been updated the way it was with the various `useEffects` and all. which is most likely the reason that the wallet popover is always rendered even when people confirm the signature.

also, i don't understand why or the essence of the nextAuth approach/files in this (#233) PR with the Cross-Site-Request-Forgery API route. What exactly were you trying to do?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.