Explore-Beyond-Innovations / Explore-Beyond-Innovations/ZeroXBridge_Contracts

Fix L1 Failing Tests

Open
#113 4 comments 0 reactions 1 assignee Claimed by @GideonBature View on GitHub
3 Days ETA bug good first issue L1 Contract
Dominant language
Cairo
Stars
4
Forks
35
PR merge metrics
No merged PRs in 30d

Description

### **Description 📹**

Several tests related to **unlocking with proofs** are failing due to configuration or implementation issues in the commitment hash validation logic. This is causing revert errors during the claim process for multiple tokens.

### **Failing Tests**

* `[FAIL: revert: ZeroXBridge: Invalid commitment hash]` **testClaimReducesTokenReserveDAI** (gas: 527,631)
* `[FAIL: revert: msgHash out of range]` **testClaimReducesTokenReserveETH** (gas: 438,766)
* `[FAIL: revert: msgHash out of range]` **testClaimReducesTokenReserveUSDC** (gas: 526,570)

Helpful links

https://github.com/Explore-Beyond-Innovations/ZeroXBridge_Contracts/pull/112#discussion_r2291688085
https://github.com/Explore-Beyond-Innovations/ZeroXBridge_Contracts/pull/112#discussion_r2291688091

### **Proposed Actions ✅**

1. Investigate the **proof verification and commitment hash logic** in the claim flow.
2. Verify that the **commitment hash** and **msgHash** are being generated and validated consistently across tests and contract logic.
3. Update configurations or logic to ensure the proof verification passes for supported tokens.
4. Run the full test suite to confirm that all failing tests are resolved.

### **Acceptance Criteria 🧾**

* All three failing tests pass successfully.
* No regression in related claim or reserve management functionality.
* Code changes are documented clearly in the PR with details on what caused the failures and how they were fixed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.