Experience-Monks / Experience-Monks/react-f1
Passing custom targets as props invalidates [data-f1] targets
- Dominant language
- JavaScript
- Stars
- 89
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
I found with the recent change I made that passing custom targets overwrites any of the targets react-f1 would have found with the data-f1 prop. You can get around this by passing those targets to the targets prop object using `refs`.
Not ideal however. I'd like to look into having the custom targets list merge with the generated list somehow.
Contributor guide
Research direction
Start by tracing how the React component handles the custom targets prop, especially its refs object, and how targets discovered through the data-f1 prop are collected. Confirm the current overwrite behavior, then verify that custom and generated target lists are both retained without breaking existing target selection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100