Excel-DNA / Excel-DNA/ExcelDna
Use AssemblyName and not ProjectName for the runtimeconfig.json
Open
Beginner friendly
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 292
- Avg merge
- 20d 12h
- Merged PRs (30d)
- 1
Description
https://github.com/Excel-DNA/ExcelDna/blob/8ae443fdfccb8a90b0f7da59f7252c837e4c439d/Source/ExcelDna.AddIn.Tasks/CreateExcelAddIn.cs#L403
Image a csproj where the user sets a custom AssemblyName
ProjectName = MyAddIn
AssemblyName = Company.MyAddIn
the produced runtimeconfig.json will be
Company.MyAddIn.runtimeconfig.json and not just simply MyAddIn.runtimeconfig.json.
Contributor guide
Research direction
Start at Source/ExcelDna.AddIn.Tasks/CreateExcelAddIn.cs around line 403 and inspect how the runtimeconfig.json filename is assembled. Reproduce the issue with ProjectName set to MyAddIn and AssemblyName set to Company.MyAddIn, then verify that the generated filename uses the assembly name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100