Excel-DNA / Excel-DNA/ExcelDna

Set launch settings in Rider

Open
#631 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
1.5k
Forks
292
Avg merge
20d 12h
Merged PRs (30d)
1

Description

While building under JetBrains Rider with both `` and `` set to true, no launchSettings.json file is being created on build.
This is caused by a condition of `ExcelDnaSetLaunchSettings` task in ExcelDna.AddIn.targets, where it is never run if `BuildingByReSharper` property is set to true (which is the case for Rider). While this condition is correct for `ExcelDnaSetDebuggerOptions` task to never try to set Visual Studio debugger options using Rider, `ExcelDnaSetLaunchSettings` task should be run with respect to
`` and `` properties.

Condition in question:
https://github.com/Excel-DNA/ExcelDna/blob/65693386abdda677668b934ff86f66df6eef5fef/Package/ExcelDna.AddIn/build/ExcelDna.AddIn.targets#L122C6-L122C6

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.