EveryVoiceTTS / EveryVoiceTTS/EveryVoice

Wizard should process g2p on datasets only once all datasets are handled.

Open
#712 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
45
Forks
4
Avg merge
1d 2h
Merged PRs (30d)
14

Description

### Bug description

Once #711 is merged, we will be able to specify custom g2p engines by language. But there is a problem: g2p engines by language are global (to the entire code base, not just the wizard), yet g2p processing is done as each dataset is processed in a given project.

We need to move g2p processing to the very end of the wizard processing pipeline, so that all custom g2p functions are declared before any data is g2p'd.

### How to reproduce the bug

Run the wizard and pick two datasets in the same language.
Keep the default g2p on the first dataset.
Set a custom g2p on the second dataset.

Observe in the *-filelist.psv files in your project that the first dataset was processed using the default g2p, and the second with the custom one, which will break model training and synthesis later, though probably only in subtle ways that would be hard to understand.

### Error messages and logs

```
# Error messages and logs here please
```

### Environment

Requires #711

### More info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.