EverestAPI / EverestAPI/Everest
Refactor DLL loading
Open
bug
rewrite
- Dominant language
- C#
- Stars
- 516
- Forks
- 106
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 5
Description
One issue is already documented in #522 , but `Loader.LoadMod` also has some issues:
- Loading an assembly from a .zip seems to always go through all zip entries even if meta.DLL is not specified, and the loop seems to be cut off early when a lua module is found, but not when a DLL is found.
- If meta.DLL is set, but the relinker fails to load the assembly (including due to a file corruption issue as in #579 ), the loader seems to just ignore that there should have been a DLL. Not sure how this differs from the case in #522 .
Contributor guide
Assessment
This issue has not been assessed yet.