EverestAPI / EverestAPI/Everest

Core tileset sound handling

Open
#494 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement
Dominant language
C#
Stars
516
Forks
106
Avg merge
4d 9h
Merged PRs (30d)
5

Description

Currently, `SolidTiles` special-cases the tileset ID `k` (`core` tileset in vanilla) to bypass `SurfaceIndex.TileToIndex` entirely and use 37, 38, or 3 as sound index depending on core mode. Tile entities do not use this special handling, which means if core mode is active, core tile entities will sound different from solid tiles. Additionally, this means any custom tileset using the ID `k` will always use core tileset sounds regardless of `sound` attribute. At least the tile entities handling should be fixed. Potentially, the custom tileset handling could also be addressed, maybe even providing a way for custom tilesets to vary sound based on core mode.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.