EverestAPI / EverestAPI/Everest

Improve compatibility with different formats of .obj file

Open
#396 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
516
Forks
106
Avg merge
4d 9h
Merged PRs (30d)
5

Description

When creating custom mountain models, it is not uncommon for someone to come to #modding_help with an unusual exception stemming from somewhere in https://github.com/EverestAPI/Everest/blob/dev/Celeste.Mod.mm/Patches/ObjModel.cs#L26. Typically, the solution is to use blender to re-export their .obj file. The vanilla Celeste code that ObjModel.CreateFromStream() is adapted from was only made with blender's .obj file format in mind and using other tools is very hit or miss.

Support for all styles of .obj files could be more trouble than it's worth, but a few simple things could be done to improve compatibility. Namely, dealing with extra spaces in the file and also potentially adding support for an alternative format I've seen used for the lines starting with `f`. This is something I was meaning to do myself at some point, but I never got around to it, and I figure leaving an issue up might help it get done.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.