Esri / Esri/solutions-data-dictionary-viewer

[Review] Stormwater Utility Network service - UI miscellaneous

Open
#55 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
11
PR merge metrics
No merged PRs in 30d

Description

http://utilsolutions.esri.com/stormwater_dd/index.html

- [x] Mimic behavior for expanding an item from a card - cursor changes to "hand".
![image](https://user-images.githubusercontent.com/50338557/74887161-032bec80-532f-11ea-900f-b17f860f31ef.png)

![image](https://user-images.githubusercontent.com/50338557/74887167-0e7f1800-532f-11ea-9fce-d545d1ac7081.png)

- [x] Also cursor changes to "hand" for filter button like for other buttons. Also had hover text tip.
![image](https://user-images.githubusercontent.com/50338557/74887289-6453c000-532f-11ea-9118-eb15be09a622.png)

- [x] The app doesn't have any name/title. Should we add a banner at the top that says "Service Explorer"? And should te browser tab also say "Service Explorer" rather than "Experience"?

- [x] Use consistent symbols for similar actions in the favorittes pane?
![image](https://user-images.githubusercontent.com/50338557/74887496-ecd26080-532f-11ea-9c32-6f98367e3c6f.png)

use these instead?
![image](https://user-images.githubusercontent.com/50338557/74887480-e47a2580-532f-11ea-9f94-296eef5c0ef6.png)

![image](https://user-images.githubusercontent.com/50338557/74887490-e93ed980-532f-11ea-9c41-cd68971854b2.png)

- [x] What is the expected behavior for the search in the favorites pane? Typing doesn't currently filter through items.
![image](https://user-images.githubusercontent.com/50338557/74887592-26a36700-5330-11ea-9809-d2aa6e22c3dd.png)

- [x] Is there a way we can add a condition to split at "_" rather than at any character?
![image](https://user-images.githubusercontent.com/50338557/74887696-800b9600-5330-11ea-8055-4df4562550c5.png)

- [x] Can we make the search be prompted also when pressing Enter on the keyboard? Right now it is required to press the search icon to trigger the search.
![image](https://user-images.githubusercontent.com/50338557/74887745-a29daf00-5330-11ea-9250-11c2fc9a5448.png)

- [x] Increase indentation between items
![image](https://user-images.githubusercontent.com/50338557/74887988-877f6f00-5331-11ea-8b47-fe1843b5dbfd.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.