Esri / Esri/solution.js

Make _updateGroupReferences more fault tolerant

Open
#565 0 comments 0 reactions 1 assignee Claimed by @dbouwman View on GitHub
Dominant language
TypeScript
Stars
48
Forks
16
PR merge metrics
No merged PRs in 30d

Description

in deploySolutioFromTemplate.ts, the `_updateGroupReferences` function blows up should any property of `templateDictionary` be `undefined`.

This function should be more tolerant here:

`const newId: string = templateDictionary[k].itemId;`

replace with

`const newId: string = getProp(templateDictionary[k], 'itemId') || '';`

We have resolved the upstream issue that was sending an `undefined` as a prop on `templateDictionary`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.