Esri / Esri/geoservices-ruby

Geoservice::Base is using `throw` for errors instead of `raise`

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
12
Forks
16
PR merge metrics
No merged PRs in 30d

Description

1. This isn't how errors are handled in Ruby
2. The parameter being passed to `throw` is unpredictable, making it impossible to catch even if we wanted to.

At minimum, the two instances of throw in this file should be changed to `raise`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.