Esri / Esri/cedar

UMD bundles include arcgis-rest-js dependencies

Open
#487 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Handlebars
Stars
265
Forks
236
PR merge metrics
No merged PRs in 30d

Description

If you search the [UMD bundle](https://unpkg.com/@esri/cedar@1.1.1/dist/umd/cedar.js) for "queryFeatures" you'll see the source for that function (as well as the source `decodeValues()` and `request()`, etc. This is despite the fact that it's marked as external:

https://github.com/Esri/cedar/blob/b4e7069383c0b8789f7024c96878e9038fbd13d8/packages/cedar/profiles/base.js#L22-L24

What makes this worse is that `package.main` points the the UMD build:

https://github.com/Esri/cedar/blob/b4e7069383c0b8789f7024c96878e9038fbd13d8/packages/cedar/package.json#L8

Originally the thinking was that we didn't want to bother making a CJS build and node could just load the UMD bundle, but now bundlers like webpack that prefer `main` over `module` will use this UMD bundle by default.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.