Esri / Esri/cedar

validate definition JSON

Open
#340 0 comments 0 reactions 0 assignees View on GitHub
Library API v1x
Dominant language
Handlebars
Stars
265
Forks
236
PR merge metrics
No merged PRs in 30d

Description

We should validate the definition JSON and it's parts (`datasets`, `series`, `type`, etc) etc. For example:
- each dataset needs a unique `name` property, and _either_ a `url` or `data` property
- each `series` needs a `source` property that refers to an existing dataset
- `type` should be one of the supported types or 'custom'

When do we run this validation? In the setters? That might mean there is an implicit sequence in which you have to set things (i.e. you can't set `series` before datasets). Or validate lazily (i.e. first thing when calling `.show()` or it's sub methods)?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.