Esri / Esri/calcite-react

useAccountManager popup improvements

Open
#465 1 comment 0 reactions 1 assignee Claimed by @brandonlammey View on GitHub
Dominant language
JavaScript
Stars
51
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Few ideas I had for improving useAccountManager, mostly when using popup.

- improved status checking
- check if popup window is currently open
- something like `const {popupOpen: boolean} = useAccountManager()`
for example: this would make it easy to display a loader on the base website while the authentication is happening in the popup window (i.e. {popupOpen && })

- callback events
- something like `useAccountManager(options, onAccountAdded : () => {}, onAccountRemoved: () => {}, onAccountsUpdated:: () => {}, onAuthCancelled: () => {})`
ex: in table editor, after authentication is finished, i want to use a callback to execute some cmds. here's how i do it now:

![image](https://user-images.githubusercontent.com/50883428/114244824-cd8ffb80-9954-11eb-9dfb-cd118be0371e.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.