Esri / Esri/calcite-bootstrap

Consider using calcite-colors instead of defining them in our Sass

Open
#225 3 comments 0 reactions 0 assignees View on GitHub
suggestions & requests
Dominant language
SCSS
Stars
49
Forks
27
PR merge metrics
No merged PRs in 30d

Description

We re-define the [calcite-colors](https://github.com/Esri/calcite-colors) in our [Sass](https://github.com/Esri/calcite-bootstrap/blob/master/lib/sass/calcite/_colors-default.scss). It might make more sense to pull in the calcite-colors repo and borrow those color vars as they could change in the future and it might be more maintainable. We could do the same with calcite-icons when it is ready.

Thoughts?

@TheBlueDog

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing lib/sass/calcite/_colors-default.scss and the linked calcite-colors repository to compare the existing definitions with the external variables. Check how Sass dependencies are currently pulled into calcite-bootstrap and whether calcite-icons is in scope. Done means the duplicated color definitions are replaced with a maintainable dependency without changing the theme's expected colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
design, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.