EscVM / EscVM/RAMS

Registration function seemingly not doing anything

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
94
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Hello @fsalv ,

I am trying to reproduce your results training a model from scratch and am having some trouble. One thing I've noticed is this:

The ``register_imgset`` function L160 returns the input ``imgset`` instead of the registered version of the images ``imgset_reg``. See here: https://github.com/EscVM/RAMS/blob/bc16e52b8e2d7b5e23560e14045f13f181d03f77/utils/preprocessing.py#L160

To me this seems like a mistake. Maybe I am missing something?

If this is a mistake, could you please advise if you think your pretrained models were affected?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.