EricssonResearch / EricssonResearch/openwebrtc

Fake video element is not fully created when when added to DOM

Open
#80 2 comments 0 reactions 0 assignees View on GitHub
All Platforms bug Non-Build Issue
Dominant language
C
Stars
1.8k
Forks
531
PR merge metrics
No merged PRs in 30d

Description

owr.js clobbers the video element with an image div but then only adds the play method after the result of renderSources() comes back from the daemon. In the meantime the page has a half-formed fake video element (without the play() method etc). This can cause the application to fail if it tries to call one of these methods before the daemon returns with the result of renderSources().

Contributor guide

Open the contributing guide

Research direction

Start by reading owr.js and tracing how the video element is replaced with an image div before renderSources() returns from the daemon. Check the fake element's creation and method assignment path. Done means the fake video element exposes its expected methods immediately after being added to the DOM, without waiting for the daemon response.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.