EnzymeAD / EnzymeAD/Reactant.jl

`Base.getindex(attr::Attribute, i)` is zero-indexed

Open
#720 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
374
Forks
75
Avg merge
18h 34m
Merged PRs (30d)
32

Description

We should make that 1-indexed for consistency.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of Base.getindex(attr::Attribute, i) and any existing tests for Attribute indexing. Confirm the current zero-based behavior and surrounding indexing conventions; done means indexing is 1-based consistently and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.