EnzymeAD / EnzymeAD/Reactant.jl

Rename functions

Open
#1,303 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
370
Forks
74
Avg merge
18h 47m
Merged PRs (30d)
30

Description

I feel like some functions names no longer fit their purpose and it would be better to rename it.

- `make_tracer`: doesn't fit because we are not _creating a tracer_ but it _traces_ through the fields of a type and returns a new type with the Reactant-managed arrays changed in some way.
- Proposals: `linearize`? `trace`?
- `make_mlir_fn`: This is a very important function because it actually performs the partial evaluation of the code inside a MLIR context and returns the emitted MLIR code. `make_mlir_fn` fits partially IMO.
- Proposals: `partial_evaluate`? `interpret`? also `trace`?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.