EngineHub / EngineHub/WorldEdit

History doesn't track passengers in vehicles

Open
#2,732 0 comments 0 reactions 0 assignees View on GitHub
status:accepted type:bug
Dominant language
Java
Stars
3.5k
Forks
960
Avg merge
6h 57m
Merged PRs (30d)
1

Description

### WorldEdit Version

7.4.0-SNAPSHOT

### Platform Version

Paper 1.21.4

### Confirmations

- [x] I am using the most recent Minecraft release.
- [x] I am using a version of WorldEdit compatible with my Minecraft version.
- [x] I am using the latest or recommended version of my platform software.
- [x] I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
- [x] I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

### Bug Description

Passengers aren't tracked with vehicles on creation, so history ignores their existence. For example when undoing a paste that contained a vehicle with a passenger, the vehicle will be removed but the passenger will just be disembarked.

### Expected Behavior

Passengers should probably be tracked separately. Alternatively, vehicles should remove their passengers on removal, but that might cause other issues if passengers change.

### Reproduction Steps

1. `//copy -e` an area with a vehicle and passenger. Or use [pig_in_a_boat.schem.gz](https://github.com/user-attachments/files/19152164/pig_in_a_boat.schem.gz) (drop the .gz from filename).

2. `//paste -e`
3. `//undo`
The vehicle will be removed, but the passenger will still be there.

### Anything Else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.